[baddest man on earth]

First script, tell me what you think.

https://github.com/zohanpbot/RuneMate/tree/master/src/com/wadiyan/runemate

 

[exia]

I would say it's aladeen.

 

[baddest man on earth]

I would say it's aladeen.

 

[cloud]

For the most part it's better than the majority of first scripts. Here's some feedback on the parts that are lacking slightly

• Interact#npc/object - You're walking in a for loop, try to avoid walking in loops. A for loop is better than a while loop but it's still suboptimal.
• Some of your constants could be made private.
• The loop delay may be a tad low, but if you need it then that's not a problem
• You should use dynamic sleeping after an interaction (via the Execution class)
• Your banking code should be revised slightly to comply with the general advice of one action per loop.

 

[baddest man on earth]

For the most part it's better than the majority of first scripts. Here's some feedback on the parts that are lacking slightly

• Interact#npc/object - You're walking in a for loop, try to avoid walking in loops. A for loop is better than a while loop but it's still suboptimal.
• Some of your constants could be made private.
• The loop delay may be a tad low, but if you need it then that's not a problem
• You should use dynamic sleeping after an interaction (via the Execution class)
• Your banking code should be revised slightly to comply with the general advice of one action per loop.

I was trying to get a feel for the API.

It does help that I've wrote scripts for 2 other bots before.

I'll probably rewrite my interact class tomorrow. It was the first class I wrote and the for loop is definitely reduntant once I realized how Path#step works.

I'll try to rework things to comply be the one-action-per-loop rule and add more dynamic sleeping.

Thanks for the fast feedback. ☺

 

[dog_]

your interact class does the same thing for npcs/object. npcs and objects are both subinterfaces of LocatableEntity so your interact class can be done with just 1 method rather than 2
see https://www.runemate.com/developer/jdocs/com/runemate/game/api/hybrid/entities/LocatableEntity.html

 

[baddest man on earth]

I've updated the script according to @Cloud 's and @dog_ 's suggestions. Tell me what you think.

 

[Falixus]

I have Al-Adeen news and Al-Adeen news:
Congratulations on your first script.

 

[baddest man on earth]

I have Al-Adeen news and Al-Adeen news:
Congratulations on your first script.

Thanks.

I've ran this for ~ 10 hours, made over 2.5 mil

 

[wyd]

Thanks.

I've ran this for ~ 10 hours, made over 2.5 mil

Add it to the SDN Pls

 

[baddest man on earth]

Add it to the SDN Pls

I pushed it to the SVN, just have to wait now.

 

[wyd]

I pushed it to the SVN, just have to wait now.

i'm so excited

 

[cloud]

I pushed it to the SVN, just have to wait now.

Rejected it for a couple small reasons, should be easy for you to fix though