[wyd]

I've made a fair few changes to MassFighter and just pushed an update for them, they should be available later today but I also need the help of some people.

Update:

- Added the ability to select multiple npcs
- Added the ability to select multiple custom loot

What do I need your help with?

I'm not that keen on implementing banking to work from anywhere and so I like the idea of a profile system, where you send me an idea (Npc names, location, loot, nearest bank) and I'll create a profile and add it to the script like this:

​

This means that I can add the ability for each profile to avoid specific obstacles, go up stairs etc. and thoroughly test each one before adding it to the script, which should hopefully bring up quality.

If you have an idea for a profile, please post here with the following information:

Description: what the profile does.
Npc names: names of the npcs you want to fight.
Location: a picture would be nice, but just let me know where they are.
Loot: what you want to loot.
Bank: nearest bank.

If you're familiar with Java, you can help me out a bunch by filling out this class for me.

Thanks!

Some tines it doing this why it getting the Cow Hides.

 

[wyd]

not banking.

 

[ozzy]

not banking.

I haven't enabled banking yet, that will come with the profiles

 

[wyd]

I haven't enabled banking yet, that will come with the profiles

 

[mukaveiii]

Hey Ozzy,

Definite props on the script. Used it to train my pure, got a few strength levels out of it.
Very excited for cowhide banking support and I really like the idea of profiles. I have one suggestion for a profile :Hill Giants

The Hill Giants in the dungeon beneath the house between Varrok and Barbarian Village
Loot Big Bones and Limpwurt Root and bank at the G.E.
There are a couple safe spots, in case of ranged/mage training. One very good one is directly to the East of the ladder, behind the stalagmite. There are three giants that are accesible from it.
The idea would be the same as the Cowhide Collector; kill Hill Giants and bank the Bones and Limpwurt Root for profit. More xp and a more profitable resours than cows.

*A Brass Key is required to get ino the house, though you can teleport directly into the dungeon with x level of dungeoneering.

 

[xcrunner]

Trying to use this to kill Chickens in OSRS, doesn't do anything.

My settings:

 

[equipment]

Trying to use this to kill Chickens in OSRS, doesn't do anything.

My settings:

click add npc and add loot

 

[ozzy]

Hey Ozzy,

Definite props on the script. Used it to train my pure, got a few strength levels out of it.
Very excited for cowhide banking support and I really like the idea of profiles. I have one suggestion for a profile :Hill Giants

The Hill Giants in the dungeon beneath the house between Varrok and Barbarian Village
Loot Big Bones and Limpwurt Root and bank at the G.E.
There are a couple safe spots, in case of ranged/mage training. One very good one is directly to the East of the ladder, behind the stalagmite. There are three giants that are accesible from it.
The idea would be the same as the Cowhide Collector; kill Hill Giants and bank the Bones and Limpwurt Root for profit. More xp and a more profitable resours than cows.

*A Brass Key is required to get ino the house, though you can teleport directly into the dungeon with x level of dungeoneering.

Thanks for the idea, I finish for Christmas soon and I'll be able to work on getting that implemented

Trying to use this to kill Chickens in OSRS, doesn't do anything.

My settings:

Sorry if it wasn't clear, you need to press add npc/loot to add your selections as stated above. I must have forgot to restrict the script from starting if an NPC hadn't been added since I did change it about a lot to allow for multiple selections.

 

[xcrunner]

Hmm could've sworn I added them in, I think I just forgot to do it in the screenshot. Gimme a sec and i'll test it

EDIT - Yup, tested it and adding the chicken/feather still reads like the screenshot I posted. Maybe have us add the ID of the monster, not the name? There's like 6 or 7 different chicken IDs. Maybe that's the problem.

 

[ozzy]

Hmm could've sworn I added them in, I think I just forgot to do it in the screenshot. Gimme a sec and i'll test it

EDIT - Yup, tested it and adding the chicken/feather still reads like the screenshot I posted. Maybe have us add the ID of the monster, not the name? There's like 6 or 7 different chicken IDs. Maybe that's the problem.

It finds the NPCs by name so Id's won't be an issue, you are above 30 hitpoints aren't you? as you set it to only fight above that and don't have food selected?

 

[xcrunner]

Ah I hadn't noticed that. Huge pebkac, sorry... Now it's saying "LootHandler is Active" as the Task Status but it isn't actually picking up the feathers around it... When I removed feathers under Loot, it says "Combat Handler is Active" and highlights a red square under the chicken it's going to attack.. but never actually clicks on it. If I manually kill the targetted chicken (without pausing the script) it never switches targets

 

[ozzy]

Ah I hadn't noticed that. Huge pebkac, sorry... Now it's saying "LootHandler is Active" as the Task Status but it isn't actually picking up the feathers around it... When I removed feathers under Loot, it says "Combat Handler is Active" and highlights a red square under the chicken it's going to attack.. but never actually clicks on it. If I manually kill the targetted chicken (without pausing the script) it never switches targets

That's very strange, I just went to the chickens on RS3 and it's killing and looting fine for me. Maybe it's something to do with OSRS... Do you have skype? If so, add ozzy.x1 and I'll try get the bottom of this

Edit: I think I know what the problem is (I think OSRS object definitions aren't available, so it can't find the loot but knows it is present), don't add any loot and see if it fights fine when it isn't looting, please let me know.

 

[xcrunner]

Tested without looting, still doesn't do anything.

Added on skype.

 

[xcrunner]

For the record, has been fixed. Awesome.

java.lang.NullPointerException
at a.PM.getProjectedPolygons(ixb:258)
at com.runemate.game.api.hybrid.local.hud.CompositeModel.getProjectedPolygons(rsb:218)
at com.runemate.game.api.hybrid.local.hud.Model.contains(neb:85)
at a.Pm.contains(qtb:196)
at a.IM.null(pmb:146)
at a.IM.null(pmb:241)
at a.IM.null(pmb:171)
at a.IM.move(pmb:110)
at com.runemate.game.api.hybrid.input.Mouse.move(rk:40)
at a.Pm.interact(qtb:20)
at a.Pm.interact(qtb:250)
at scripts.MassFighter.Tasks.CombatHandler.execute(CombatHandler.java:57)
at com.runemate.game.api.script.framework.task.TaskScript.onLoop(ohb:274)
at com.runemate.game.api.script.framework.LoopingScript.run(pjb:101)
at com.runemate.game.api.script.framework.AbstractScript.start(xfb:137)
at a.Hj.run(reb:152)

Was killing chickens in lumby, that happened.

java.lang.NullPointerException

Also had that one happen... was like "Wtf.." Same thing, chickens.

Got this one just now:

java.lang.NullPointerException
at a.PM.getProjectedPolygons(ixb:258)
at com.runemate.game.api.hybrid.local.hud.Model.contains(neb:85)
at a.Pm.contains(qtb:196)
at a.IM.null(pmb:146)
at a.IM.null(pmb:241)
at a.IM.null(pmb:241)
at a.IM.null(pmb:241)
at a.IM.null(pmb:241)
at a.IM.null(pmb:171)
at a.IM.move(pmb:110)
at com.runemate.game.api.hybrid.input.Mouse.move(rk:40)
at a.Pm.interact(qtb:20)
at a.Pm.interact(qtb:250)
at scripts.MassFighter.Tasks.CombatHandler.execute(CombatHandler.java:57)
at com.runemate.game.api.script.framework.task.TaskScript.onLoop(ohb:274)
at com.runemate.game.api.script.framework.LoopingScript.run(pjb:101)
at com.runemate.game.api.script.framework.AbstractScript.start(xfb:137)
at a.Hj.run(reb:152)

Which is basically the exact same as the first, but more pmb:241


SUGGESTION: Could you have bone burying support?

 

[ozzy]

For the record, has been fixed. Awesome.
SUGGESTION: Could you have bone burying support?

I've reported those errors as I believe they are out of my control and yeah sure I'll add bone burying for the next release. Thanks for the feedback

 

[roflcopter19]

Looking forward to the profile system! How about another preset for rock crabs?

 

[ozzy]

Looking forward to the profile system! How about another preset for rock crabs?

That would be no trouble, I'll have that one done tonight. Just trying to work out a good way of handling profiles that have lots of obstacles which is making it take some time

 

[xcrunner]

Is there a way to put in a goal system? Like have it train to 10 attk/30str/10 def and stop?

 

[ozzy]

Is there a way to put in a goal system? Like have it train to 10 attk/30str/10 def and stop?

It's possible, could be something to add after I've sorted the profile system out.

 

[darkflame]

It's working great, really helping me level up my new account However, it sometimes waits like 20 seconds (sleep?) before attacking another monster when it has already killed a monster. Another bug would be that it moves the mouse behind the interface hovering over the monster trying to click it, but it can't since the interface is in the way. It is soon corrected when a) the monster moves into screen view or b) it turns the camera/walks to it

Just minor bugs, still works perfectly fine though Can't wait for banking support!