[tyrone]

Hello.

I've noticed that a few methods could benefit from the usage of iterable data types. Name ones such as:

• Inventory#containsAllOf(int[])
• Bank#containsAnyOf(int[])
• GroundItems#getLoaded(String[])

Just to name a few. This could work quite well with the changes to collections from Java 8.

I don't see this being particularly useful in simpler, more commonly run scripts; but, it could very well have its niche.

Haven't been here long, so I wouldn't know if/when this was discussed before.


For further clarification, what I am suggesting is like such:

List<Integer> userDefinedIDs = ...;
// ...
LocatableEntityQueryResults<GroundItem> query = GroundItems.getLoaded(userDefinedIDs);


Set<String> userDefinedNames = ...;
// ...
LocatableEntityQueryResults<Npc> query = Npcs.getLoaded(userDefinedNames);

And the such.

Just a quick look shows that the following could benefit from this:

1. Bank
2. GroundItems
3. Inventory
4. Npcs
5. Players

Thanks,

~T

 

[cloud]

Can you elaborate a bit more on what you're asking for?

 

[tyrone]

Can you elaborate a bit more on what you're asking for?

Updated accordingly.

 

[cloud]

Updated accordingly.

So just overloads for collections?

 

[tyrone]

So just overloads for collections?

Effectively.

Saves the hassle of having to convert it to an array before calling one of these methods.

This is also Java 8 where the collections have far more usage.

 

[cloud]

I'll go ahead and add the overloads in a few frequently used places.
 
I began to do this with Collection overloads but I've began to run into a few signature erasure issues so I'll have to look into it and be a bit more selective.

 

[tyrone]

I'll go ahead and add the overloads in a few frequently used places.
 
I began to do this with Collection overloads but I've began to run into a few signature erasure issues so I'll have to look into it and be a bit more selective.

That was definitely a downside to this. The way this has been circumvented before was just to do

containsAllOfNames(Iterable<String>)
containsAllOfIds(Iterable<Integer>)

I understand if you wouldn't feel comfortable compromising the integrity of the names. I'd sooner tear my own hairs out than drop my linearity. This was merely a suggestion of opportunity and not requirement.

Most of these also pertain to items. So maybe some trickery with the ItemDefinition's could be had. Although, at that point, it would almost become more efficient just to drop the notion and call forth an array.