[divinity]

So in my fisher i have this code once the inventory is full, I know it reaches this point as I am debugging every step and the debug logs show it to be in this phase...

It does Drop only ONE fish out of the 26 in inventory...
Theoretically either i'm just completely stupid or it should work?

 

[viewer]

I think thats because you stored the fish you want to drop.. lets say that your dropAll variable gets a fish on slot 20, if you drop it, that item will be null so you cant drop it anymore, inside your while loop, you should loop through all items in your inventory and interact with any item with the "raw" string. Try it

 

[booch]

What viewer is saying is correct. The SpriteItem is being declared and assigned once as a single RandomItem so try putting that underneath your while loop so the dropAll will be assigned every time to another fish through each loop

 

[divinity]

New issue: It drops about 5 and then stops the script...

 

[viewer]

New issue: It drops about 5 and then stops the script...

Can you post the stack trace (if there is an error thrown in the console) ?

 

[dog_]

dropAll is only one SpriteItem. Please post the stacktrace and/or your new code

 

[booch]

New issue: It drops about 5 and then stops the script...

Very strange how it would only drop 5.. mind posting your new code?

 

[cloud]

I'm almost positive that's it's an issue with your code if it's only dropping 5.

 

[divinity]

I'm almost positive that's it's an issue with your code if it's only dropping 5.

100% I am just trying to get direction as to where in my code it's happening, i knew it wasnt client related with 2nd bug

 

[cloud]

100% I am just trying to get direction as to where in my code it's happening, i knew it wasnt client related with 2nd bug

Did you post your updated code?

 

[divinity]

@Cloud

 

[divinity]

Issue Resolved forgot to add the execution delay, lock thread

 

[salvation]

@Cloud

dropAll is null, this frequently happens between gameticks, while a new region is loaded or the user is having minor connectivity issues.
As for the actual programming, containsAnyOf uses getItem and getRandomItem uses getItem: you're calling it twice, while that is not needed!

    private void dropInventory() {
        SpriteItem item = null;
        //Iterate a maximum of 28 times, in case we are somehow unable to actually drop items at all
        for (int i = 0; i < 28 && (item = Inventory.getRandomItem("Raw trout", "Raw salmon")) != null; i++) {
            if (item.interact("Drop")) {
                //Sucessfully dropped, might want to sleep a little bit or not
            }
        }
    }

 

[viewer]

Try this:

   public void drop(String... itemNames) {
        while(Inventory.containsAnyOf(itemNames)) {
            for (final SpriteItem item : Inventory.getItems()) {
                for (String name : itemNames) {
                    if(item != null && item.getDefinition().getName().toLowerCase().contains(name.toLowerCase())) {
                        if (item.interact("Drop")) {
                            Execution.delay(210,280);
                        }
                    }
                }
            }
        }
    }

 

[divinity]

Issue was already solved, i fixed it thanks

I had a update thread here: http://runemate.com/community/threads/dev-extreme-aio-fisher.255/