[tztok]

Suggestion: add equals method for Area class
You have toString but no equals?

 

[party]

Emmmm.... area1.equals(area2) ????????????

Or Objects.equals(area1, area2)

 

[serene]

What?

Methods inherited from class java.lang.Object:
equals

 

[party]

Just to add to that, in case you aren't that familiar with Java:

All objects in Java inherit from class Object, meaning you can use any of the methods listed below with any object.
Object (Java Platform SE 7 )

 

[serene]

I still get marked as best answer tho

 

[party]

No best answer available for posts marked Suggestion I'm afraid 8)

 

[tztok]

Just to add to that, in case you aren't that familiar with Java:

All objects in Java inherit from class Object, meaning you can use any of the methods listed below with any object.
Object (Java Platform SE 7 )

it isnt implemented?

 

[serene]

What kind of site is this ffs
 

it isnt implemented?

Yeah test it out.

private Area randomArea;
randomArea.equals() should work.

 

[party]

it isnt implemented?

What do you mean? Read my post slowly and carefully.

 

[tztok]

What do you mean? Read my post slowly and carefully.

If you dont overrride it you cant use it like arraylist.contains(area)
returns false

 

[party]

Ehhhhhhhhhhhhh ????????????????

 

[tztok]

Ehhhhhhhhhhhhh ????????????????

try it

 

[party]

try it

try it:

        Area area1 = new Area.Circular(new Coordinate(0, 0, 0), 2);
        Area area2 = new Area.Circular(new Coordinate(0, 0, 0), 2);
        System.out.println(area1.equals(area2));
       
        area1 = new Area.Circular(new Coordinate(0, 0, 0), 5);
        System.out.println(area1.equals(area2));

 

[tztok]

try it:

        Area area1 = new Area.Circular(new Coordinate(0, 0, 0), 2);
        Area area2 = new Area.Circular(new Coordinate(0, 0, 0), 2);
        System.out.println(area1.equals(area2));
     
        area1 = new Area.Circular(new Coordinate(0, 0, 0), 5);
        System.out.println(area1.equals(area2));

I meant this:

    public static final List<Area.Rectangular> nodes = Arrays.asList(
            new Area.Rectangular(new Coordinate(4678, 3439, 0), new Coordinate(1678, 3537, 0))
    );

    println(nodes.contains(new Area(new Coordinate(4678, 3439, 0), new Coordinate(1678, 3537, 0))));

 

try it:

        Area area1 = new Area.Circular(new Coordinate(0, 0, 0), 2);
        Area area2 = new Area.Circular(new Coordinate(0, 0, 0), 2);
        System.out.println(area1.equals(area2));
     
        area1 = new Area.Circular(new Coordinate(0, 0, 0), 5);
        System.out.println(area1.equals(area2));

both print false


if you dont override it, then it will use this from Object:

public boolean equals(Object obj) {
    return (this == obj);
}

This wont compare the coordinates.

 

[party]

I meant this:

    public static final List<Area.Rectangular> nodes = Arrays.asList(
            new Area.Rectangular(new Coordinate(4678, 3439, 0), new Coordinate(1678, 3537, 0))
    );

    println(nodes.contains(new Area(new Coordinate(4678, 3439, 0), new Coordinate(1678, 3537, 0))));

 


both print false

Probably, neither are valid coordinates (goof example). If you were to do it with Integers/anything else, you would get the point.

What is it you're trying to accomplish? Whatever you're doing currently, it's probably wrong.

public static void main(String[] args) {
    Integer i1 = 2;
    Integer i2 = 2;
    List<Integer> ints = Arrays.asList(new Integer(2)); //Unnecessary boxing but for example's sake
    List<Integer> ints2 = Arrays.asList(i2);

    System.out.println(i1.equals(i2));
    System.out.println(i1 == i2); //bad, don't do
    System.out.println(Objects.equals(i1, i2));
    System.out.println(ints.contains(i1));
    System.out.println(ints.contains(i2));
    System.out.println(ints2.contains(i1));
    System.out.println(ints.contains(i2));
    System.out.println(ints.contains(2));
    System.out.println(ints2.contains(2));

}

true
true
true
true
true
true
true
true
true

 

[tztok]

Probably, neither are valid coordinates (goof example). If you were to do it with Integers/anything else, you would get the point.

What is it you're trying to accomplish? Whatever you're doing currently, it's probably wrong.

public static void main(String[] args) {
    Integer i1 = 2;
    Integer i2 = 2;
    List<Integer> ints = Arrays.asList(new Integer(2)); //Unnecessary boxing but for example's sake
    List<Integer> ints2 = Arrays.asList(i2);

    System.out.println(i1.equals(i2));
    System.out.println(i1 == i2); //bad, don't do
    System.out.println(Objects.equals(i1, i2));
    System.out.println(ints.contains(i1));
    System.out.println(ints.contains(i2));
    System.out.println(ints2.contains(i1));
    System.out.println(ints.contains(i2));
    System.out.println(ints.contains(2));
    System.out.println(ints2.contains(2));

}

true
true
true
true
true
true
true
true
true

Those are true because class Integer overrides the equals method:

public boolean equals(Object obj) {
    if (obj instanceof Integer) {
        return value == ((Integer)obj).intValue();
    }
    return false;
}

 

[alibalhari]

@Party ur getting rekt by this support

 

[party]

@Party ur getting rekt by this support

wouldn't surprise me - not to be making excuses but I've driven for 12 hours today so my brain is melting away at the edges

let me sleep and I'll come back and tell you either A. why you're wrong or B. how you could do it

 

[serene]

@Party ur getting rekt by this support

How? There aren't many if any cases where it's necessary to compare a list of coordinates of areas (area vs area) unless making a dynamic list of them, which I don't really see a useful purpose for unless creating a dev tool for mapping areas - and even then you could just compare direct coordinates (which does have a direct equals override). Not a bad suggestion but there are workarounds and for something so small, eh.

party u better find a way to make best answers on suggestion posts and mark me as one tho, ik you have the power to

 

[tztok]

wouldn't surprise me - not to be making excuses but I've driven for 12 hours today so my brain is melting away at the edges

let me sleep and I'll come back and tell you either A. why you're wrong or B. how you could do it

Ofc there is a work around, but its kinda annoying.
I was just posting a suggestion to make this easier.