Welcome!

By registering with us, you'll be able to discuss, share and private message with other members of our community.

Sign up now!

RuneMate V1.0.0 Beta 12

Engineer
Joined
Jul 28, 2013
Messages
2,776
  • You can now release a bot as open source by setting the open_source manifest flag to true. Users can download the source code of open source scripts directly from the bot store by pressing the cloud button in the store entry.
  • Redone random event handling system
  • The definition methods are now thread-safe and should no longer cause any issues.
  • Moved EventProcesssor from api.script.framework to api.script.framework.core
  • Rewrote ActionBar, Bank, and Equipment to be up to date and far more dynamic on both OSRS and RS3.
  • Java 8 UI/UX patches. Should be fully operational. Please report any graphical bugs you notice.
  • Revamped play/pause/stop buttons to match the variations in color palette.
 
First Bot Author
Joined
Aug 7, 2013
Messages
262
Please make this return true if and only if a step was taken, the current return value is useless as it pretty much always returns true, even if it doesn't do anything at all.

  • public boolean step(boolean manage)
    Description copied from interface: Path
    Takes a step along the path, waiting until closer if specified
    Specified by:
    step in interface Path
    Parameters:
    manage - whether or not to manage the distance between steps to prevent spam clicking
    Returns:
    true if it took a step or it's yet time to, otherwise false
 
First Bot Author
Joined
Aug 7, 2013
Messages
262
Given the following code:
Code:
Player player = Players.getLocal();
            for (final Npc npc : Npcs.getLoaded()) {
                final Actor actor = npc.getInteractingEntity();
                if (actor != null && actor.equals(player)) {
                    return false; //Player is under attack, abort
                }
            }

This would never return false, even when it should be returning false.
The following fixed it:
Code:
if (actor != null && actor.getName().equals(player.getName())) {

Therefore, I have reasons to believe actor.equals(Object) is a bit off
 
First Bot Author
Joined
Aug 7, 2013
Messages
262
Another thing:
88NEa.png


I'm sure you know what I mean :p
 
Engineer
Joined
Jul 28, 2013
Messages
2,776
Please make this return true if and only if a step was taken, the current return value is useless as it pretty much always returns true, even if it doesn't do anything at all.

  • public boolean step(boolean manage)
    Description copied from interface: Path
    Takes a step along the path, waiting until closer if specified
    Specified by:
    step in interface Path
    Parameters:
    manage - whether or not to manage the distance between steps to prevent spam clicking
    Returns:
    true if it took a step or it's yet time to, otherwise false
coordinate.distanceTo should take Locatable as argument, please <3
Done.
 
Engineer
Joined
Jul 28, 2013
Messages
2,776
Given the following code:
Code:
Player player = Players.getLocal();
            for (final Npc npc : Npcs.getLoaded()) {
                final Actor actor = npc.getInteractingEntity();
                if (actor != null && actor.equals(player)) {
                    return false; //Player is under attack, abort
                }
            }

This would never return false, even when it should be returning false.
The following fixed it:
Code:
if (actor != null && actor.getName().equals(player.getName())) {

Therefore, I have reasons to believe actor.equals(Object) is a bit off
Updated Entity.equals
 
Author of MaxiBots
Joined
Dec 3, 2013
Messages
6,771
Looking good cloud :) Just wondering if there's a method like Tile.canReach()? Couldn't see one in the api last time i gave it a quick look over.
 
Discretion is advised
Joined
Jan 2, 2014
Messages
306
Looking good cloud :) Just wondering if there's a method like Tile.canReach()? Couldn't see one in the api last time i gave it a quick look over.

Not in OSRS (yet), but you can use coordinate#isReachable for RS3
 
Top