[ciihangiir]

When there appears an NPC to Dismiss and the bot banks (what a timing), the bot tries to dismiss by moving the mouse in my bank and does nothing.

 

[slashnhax]

In your personal opinion, should it close the bank or just ignore the Npc?
@Party tagging you for discussion

 

[ciihangiir]

I think it would be nice if it close the bank and dismiss the npc, that is how a human reaction will be. Instead of moving the cursor in my bank to an item what I'm not botting and trying to dismiss.

 

[arbiter]

In your personal opinion, should it close the bank or just ignore the Npc?
@Party tagging you for discussion

Ignore. The NPC does not affect what the user is trying to do and is likely not even visible to the user. It would be bot-like for us to react to something a user wouldn't even know.

 

[party]

In your personal opinion, should it close the bank or just ignore the Npc?
@Party tagging you for discussion

Should either:
A. Close bank and dismiss
B. Ignore NPC completely and continue with bot logic.

B is preferable, legitimate players do not close their bank just to dismiss an NPC and the handler should really be considering this, because waiting for the bot to logout isn't really acceptable. Checking for Bank.isOpen() after checking for the NPC would add no unnecessary overhead.

 

[ciihangiir]

Should either:
A. Close bank and dismiss
B. Ignore NPC completely and continue with bot logic.

B is preferable, legitimate players do not close their bank just to dismiss an NPC and the handler should really be considering this, because waiting for the bot to logout isn't really acceptable. Checking for Bank.isOpen() after checking for the NPC would add no unnecessary overhead.

Yes, B is the most sensible.
I saw the NPC it didn't dismiss it just banked and stuck tries to dismiss. So it would be better if it banks, takes the item that is need and then tries to dismiss npc.
If this is possible to write, it would be awesome.

 

[slashnhax]

Should either:
A. Close bank and dismiss
B. Ignore NPC completely and continue with bot logic.

B is preferable, legitimate players do not close their bank just to dismiss an NPC and the handler should really be considering this, because waiting for the bot to logout isn't really acceptable. Checking for Bank.isOpen() after checking for the NPC would add no unnecessary overhead.

After or before? I think Bank.isOpen() is more lightweight than an Npc query.

 

[party]

After or before? I think Bank.isOpen() is more lightweight than an Npc query.

If the query is before we'd be making both calls every iteration other than when the bank is open, which can't be more than 5% of the time.

Having it after means we'd only be making the one call every iteration until the NPC was found.

 

[slashnhax]

If the query is before we'd be making both calls every iteration other than when the bank is open, which can't be more than 5% of the time.

Having it after means we'd only be making the one call every iteration until the NPC was found.

Hmmm, frequency vs expensiveness, didn't think of it that way xD

 

[cloud]

I'll handle this because even now that query is way too expensive.