Welcome!

By registering with us, you'll be able to discuss, share and private message with other members of our community.

Sign up now!

Resolved Quests.get("Cook's Assistant").getStatus() not working properly.

Joined
Jun 8, 2017
Messages
184
Quests.get("Cook's Assistant").getStatus();

Takes about 300 - 400 ms and returns the wrong Quest.Status (IN_PROGRESS instead of
COMPLETE) on OSRS even with the quest tab open.

Plz fix.

While I'm complaining :p, can we also get the quests as Enums?

Don't know who is in charge of this so I'll just tagg some ppl:
@Cloud
@Party
@EvilCabbage
 
Engineer
Joined
Jul 28, 2013
Messages
2,776
My apologies for taking so long to respond to this, I had to go ahead and find time/an account to perform the quest on to begin with. First of all, this bug is resolved in the next release, very nice catch :). Secondly, the initial "300-400ms" (which fyi that seems higher than I'd expect by a long shot) was it trying to open the quest tab so that it could read quest states (and then cache them so that it wouldn't have to be opened again). However, the code shouldn't have even needed to do that because that is one of the quests that we have the start and finishing varp value for. Because of this I looked further and discovered that if the quest data had not already been cached, even when looking up a quest with defined varp/varbit data that indicates their states (which shouldn't require it to open up the quest tab), it was still opening the quest tab anyways. This behavior has been changed so that now it only opens up the quest tab when it needs the data for the desired quest, as it should have been all along. Thanks for uncovering this because it made me find a much larger issue that I'm glad I've addressed in the next build :) @SilenceP44
 
Joined
Jun 8, 2017
Messages
184
My apologies for taking so long to respond to this, I had to go ahead and find time/an account to perform the quest on to begin with. First of all, this bug is resolved in the next release, very nice catch :). Secondly, the initial "300-400ms" (which fyi that seems higher than I'd expect by a long shot) was it trying to open the quest tab so that it could read quest states (and then cache them so that it wouldn't have to be opened again). However, the code shouldn't have even needed to do that because that is one of the quests that we have the start and finishing varp value for. Because of this I looked further and discovered that if the quest data had not already been cached, even when looking up a quest with defined varp/varbit data that indicates their states (which shouldn't require it to open up the quest tab), it was still opening the quest tab anyways. This behavior has been changed so that now it only opens up the quest tab when it needs the data for the desired quest, as it should have been all along. Thanks for uncovering this because it made me find a much larger issue that I'm glad I've addressed in the next build :) @SilenceP44


Ty, will look at your work when I have time :).
 
Top