[boot]

Hey,
I found an issue with using Familiar in action bar. It doesn't grab the right slot or key bind.
Game Mode: RS3
Reproduce: Have an item in slot 1. Put familiar in slot 2. Put Super heat and some other spell in slot 3 and 4. If you call ActionBar.getFilledSlots() and check the keybinds and index the Familiar will always be in the fourth slot The keybind will also be set to "4".

Thanks,
Boot

 

[infinite inferno]

@SlashnHax @Party

 

[cloud]

I wasn't aware you could place a familiar in the actionbar, can you supply me with a test account?
 
After preliminary investigations, it appears that 3 of the 4 orbs on the actionbar can be placed into slots (regenerate, toggle quick prayers, and open familiar options) and all 3 of them cause weird issues to occur. @Party can you take it from here?

 

[boot]

I wasn't aware you could place a familiar in the actionbar, can you supply me with a test account?
 
After preliminary investigations, it appears that 3 of the 4 orbs on the actionbar can be placed into slots (regenerate, toggle quick prayers, and open familiar options) and all 3 of them cause weird issues to occur. @Party can you take it from here?

I wasn't either until I started making the runecrafter. I tried to get around the issue with a check for s.getName() == null (s being ActionBar.Slot) but it's still switching it around in the action bar so that didn't resolve my issue.I'm not sure what other objects can cause issues though. If you need an account or need me to test out anything else please let me know.

Thanks for looking into this @Cloud & @Party

@Party
 
Reminder - @Party @SlashnHax

Please and thank you.

 

[justcurious]

@Party @Cloud @SlashnHax

An easy to implement workaround until a proper fix is made would be to add an ID search to ActionBarQueryBuilder (ie ActionBar.newQuery().ids(int)) similar to inventory or bank commands.

For reference, interacting with familiar is ID 29, and items added to the action bar all use the same item IDs that they do in the inventory.

 

[cloud]

Is this still an issue?

 

[boot]

Is this still an issue?

@Cloud, No, I fixed it and gave the solution to @Party . I'm pretty sure it's already in the client but not 100% sure because he hasn't posted the change log yet.

However, getName() for Familiar is still null so might be worth looking into.

 

[party]

@Cloud, No, I fixed it and gave the solution to @Party . I'm pretty sure it's already in the client but not 100% sure because he hasn't posted the change log yet.

However, getName() for Familiar is still null so might be worth looking into.

It went in - when I do the next changelog you'll be credited @Boot.